diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2015-07-08 13:06:12 -0400 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-08-04 14:20:15 -0400 |
| commit | ed290a16f30c83e3d5cb3462a5b7b1367cc5faee (patch) | |
| tree | d7560d05f5a93568343e37f3237e1ead5b417340 /drivers/ata | |
| parent | dba1319c94b1d257b5883e1db8b3f0b4fa940d54 (diff) | |
| download | lwn-ed290a16f30c83e3d5cb3462a5b7b1367cc5faee.tar.gz lwn-ed290a16f30c83e3d5cb3462a5b7b1367cc5faee.zip | |
libata: increase the timeout when setting transfer mode
[ Upstream commit d531be2ca2f27cca5f041b6a140504999144a617 ]
I have a ST4000DM000 disk. If Linux is booted while the disk is spun down,
the command that sets transfer mode causes the disk to spin up. The
spin-up takes longer than the default 5s timeout, so the command fails and
timeout is reported.
Fix this by increasing the timeout to 15s, which is enough for the disk to
spin up.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b39ea7beb867..39c946670f5b 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4468,7 +4468,8 @@ static unsigned int ata_dev_set_xfermode(struct ata_device *dev) else /* In the ancient relic department - skip all of this */ return 0; - err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 0); + /* On some disks, this command causes spin-up, so we need longer timeout */ + err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 15000); DPRINTK("EXIT, err_mask=%x\n", err_mask); return err_mask; |