diff options
| author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2016-04-01 08:52:57 +0100 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2016-04-01 10:30:30 -0400 |
| commit | 17dcc37e3e847bc0e67a5b1ec52471fcc6c18682 (patch) | |
| tree | e5219e173278994cc4dc42e941237abafe16bf88 /drivers/ata/ahci_platform.c | |
| parent | 2fd0f46cb1b82587c7ae4a616d69057fb9bd0af7 (diff) | |
| download | lwn-17dcc37e3e847bc0e67a5b1ec52471fcc6c18682.tar.gz lwn-17dcc37e3e847bc0e67a5b1ec52471fcc6c18682.zip | |
ata: ahci-platform: Add ports-implemented DT bindings.
On some SOCs PORTS_IMPL register value is never programmed by the
firmware and left at zero value. Which means that no sata ports are
available for software. AHCI driver used to cope up with this by
fabricating the port_map if the PORTS_IMPL register is read zero,
but recent patch broke this workaround as zero value was valid for
NVMe disks.
This patch adds ports-implemented DT bindings as workaround for this issue
in a way that DT can can override the PORTS_IMPL register in cases where
the firmware did not program it already.
Fixes: 566d1827df2e ("libata: disable forced PORTS_IMPL for >= AHCI 1.3")
Cc: stable@vger.kernel.org # v4.5+
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/ahci_platform.c')
| -rw-r--r-- | drivers/ata/ahci_platform.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 40442332bfa7..62a04c8fb5c9 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -51,6 +51,9 @@ static int ahci_probe(struct platform_device *pdev) if (rc) return rc; + of_property_read_u32(dev->of_node, + "ports-implemented", &hpriv->force_port_map); + if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci")) hpriv->flags |= AHCI_HFLAG_NO_FBS | AHCI_HFLAG_NO_NCQ; |