diff options
| author | Veaceslav Falico <vfalico@redhat.com> | 2013-03-12 06:31:32 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-28 12:11:52 -0700 |
| commit | e7778a61fff957a36c0e53fc565df17d68dcbee6 (patch) | |
| tree | c9a766abdae5ac9803ddc6fe37b5050d600c17d5 /drivers/acpi | |
| parent | b52f06719c794cc8df5ea871a4fd498ff252210a (diff) | |
| download | lwn-e7778a61fff957a36c0e53fc565df17d68dcbee6.tar.gz lwn-e7778a61fff957a36c0e53fc565df17d68dcbee6.zip | |
bonding: don't call update_speed_duplex() under spinlocks
[ Upstream commit 876254ae2758d50dcb08c7bd00caf6a806571178 ]
bond_update_speed_duplex() might sleep while calling underlying slave's
routines. Move it out of atomic context in bond_enslave() and remove it
from bond_miimon_commit() - it was introduced by commit 546add79, however
when the slave interfaces go up/change state it's their responsibility to
fire NETDEV_UP/NETDEV_CHANGE events so that bonding can properly update
their speed.
I've tested it on all combinations of ifup/ifdown, autoneg/speed/duplex
changes, remote-controlled and local, on (not) MII-based cards. All changes
are visible.
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/acpi')
0 files changed, 0 insertions, 0 deletions