diff options
| author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2020-03-06 00:14:35 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2020-03-14 11:04:17 +0100 |
| commit | 98ada3c59d05e6c41f35fe1f7e5a550c1536be45 (patch) | |
| tree | d1ec50ff2c994687f3a463803ff64b66118eaf38 /drivers/acpi/internal.h | |
| parent | 03e9a0e05739cf872fee494b06c75c0469704a21 (diff) | |
| download | lwn-98ada3c59d05e6c41f35fe1f7e5a550c1536be45.tar.gz lwn-98ada3c59d05e6c41f35fe1f7e5a550c1536be45.zip | |
ACPI: EC: Simplify acpi_ec_ecdt_start() and acpi_ec_init()
Notice that the return value of acpi_ec_init() is discarded anyway,
so it can be void and it doesn't need to check the return values of
acpi_bus_register_driver() and acpi_ec_ecdt_start() called by it.
Thus the latter can be void too and it really has nothing to do
if acpi_ec_add() has already found an EC matching the boot one in the
namespace. Also, acpi_ec_ecdt_get_handle() can be folded into it.
Modify the code accordingly and while at it create a propoer kerneldoc
comment to document acpi_ec_ecdt_start() and move the remark regarding
ASUS X550ZE along with the related bug URL from acpi_ec_init() into
that comment.
Additionally, fix up a stale comment in acpi_ec_init().
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/internal.h')
| -rw-r--r-- | drivers/acpi/internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 3616daec650b..43411a7457cd 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -190,7 +190,7 @@ extern struct acpi_ec *first_ec; /* External interfaces use first EC only, so remember */ typedef int (*acpi_ec_query_func) (void *data); -int acpi_ec_init(void); +void acpi_ec_init(void); void acpi_ec_ecdt_probe(void); void acpi_ec_dsdt_probe(void); void acpi_ec_block_transactions(void); |