diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2015-12-30 20:24:17 +0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-02-24 09:24:09 +0100 |
| commit | b9da7c51a11a2e7b625122905109e8737fcfbe07 (patch) | |
| tree | 36e29716ea96939c559e7c45b15eda29790fd12e /crypto | |
| parent | 79adba68c32883c6559dc80040e97c35e208c7f1 (diff) | |
| download | lwn-b9da7c51a11a2e7b625122905109e8737fcfbe07.tar.gz lwn-b9da7c51a11a2e7b625122905109e8737fcfbe07.zip | |
crypto: af_alg - Fix socket double-free when accept fails
commit a383292c86663bbc31ac62cc0c04fc77504636a6 upstream.
When we fail an accept(2) call we will end up freeing the socket
twice, once due to the direct sk_free call and once again through
newsock.
This patch fixes this by removing the sk_free call.
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/af_alg.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/crypto/af_alg.c b/crypto/af_alg.c index d7fefeb3d1a7..0ca108f3c840 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -275,10 +275,8 @@ int af_alg_accept(struct sock *sk, struct socket *newsock) security_sk_clone(sk, sk2); err = type->accept(ask->private, sk2); - if (err) { - sk_free(sk2); + if (err) goto unlock; - } sk2->sk_family = PF_ALG; |