diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-02-21 12:04:23 -0600 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-02-28 14:17:59 +0800 |
| commit | 91e14842f8ea8dc35669bad3c3dcd72d4614e4d1 (patch) | |
| tree | 66a5c434d5f741a05e38613a849bbade3690e65e /crypto | |
| parent | 867659c63762b8e2b77102aa1c9b5d31e32b0690 (diff) | |
| download | lwn-91e14842f8ea8dc35669bad3c3dcd72d4614e4d1.tar.gz lwn-91e14842f8ea8dc35669bad3c3dcd72d4614e4d1.zip | |
crypto: af_alg - use struct_size() in sock_kfree_s()
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.
So, change the following form:
sizeof(*sgl) + sizeof(sgl->sg[0]) * (MAX_SGL_ENTS + 1)
to :
struct_size(sgl, sg, MAX_SGL_ENTS + 1)
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/af_alg.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crypto/af_alg.c b/crypto/af_alg.c index c5937c812799..0f1032064340 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -635,8 +635,7 @@ void af_alg_pull_tsgl(struct sock *sk, size_t used, struct scatterlist *dst, } list_del(&sgl->list); - sock_kfree_s(sk, sgl, sizeof(*sgl) + sizeof(sgl->sg[0]) * - (MAX_SGL_ENTS + 1)); + sock_kfree_s(sk, sgl, struct_size(sgl, sg, MAX_SGL_ENTS + 1)); } if (!ctx->used) |