diff options
| author | Eric Biggers <ebiggers@google.com> | 2019-01-06 12:46:06 -0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2019-01-11 14:16:58 +0800 |
| commit | 6b476662b09c393936e0f62c97ad9988d410fd36 (patch) | |
| tree | 46b91d53182b9d37f525880ffde90eae2201e267 /crypto/algapi.c | |
| parent | 14aa1a839a33b4ade7479ffcad8a5fabe5cc4000 (diff) | |
| download | lwn-6b476662b09c393936e0f62c97ad9988d410fd36.tar.gz lwn-6b476662b09c393936e0f62c97ad9988d410fd36.zip | |
crypto: algapi - reject NULL crypto_spawn::inst
It took me a while to notice the bug where the adiantum template left
crypto_spawn::inst == NULL, because this only caused problems in certain
cases where algorithms are dynamically loaded/unloaded.
More improvements are needed, but for now make crypto_init_spawn()
reject this case and WARN(), so this type of bug will be noticed
immediately in the future.
Note: I checked all callers and the adiantum template was the only place
that had this wrong. So this WARN shouldn't trigger anymore.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto/algapi.c')
| -rw-r--r-- | crypto/algapi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/crypto/algapi.c b/crypto/algapi.c index f3d766312bd9..713baabeb643 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -608,6 +608,9 @@ int crypto_init_spawn(struct crypto_spawn *spawn, struct crypto_alg *alg, { int err = -EAGAIN; + if (WARN_ON_ONCE(inst == NULL)) + return -EINVAL; + spawn->inst = inst; spawn->mask = mask; |