diff options
author | Eric Biggers <ebiggers@google.com> | 2020-10-26 09:31:12 -0700 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2020-11-06 14:29:10 +1100 |
commit | 09a5ef9644bc0e167984136b711eb08206733af8 (patch) | |
tree | 2fd7b5f92c8bd2b5396055d95fe9b1a22438880b /certs | |
parent | 6e5972fa4a0db6912714d465485bdae91a99ccc2 (diff) | |
download | lwn-09a5ef9644bc0e167984136b711eb08206733af8.tar.gz lwn-09a5ef9644bc0e167984136b711eb08206733af8.zip |
crypto: testmgr - WARN on test failure
Currently, by default crypto self-test failures only result in a
pr_warn() message and an "unknown" status in /proc/crypto. Both of
these are easy to miss. There is also an option to panic the kernel
when a test fails, but that can't be the default behavior.
A crypto self-test failure always indicates a kernel bug, however, and
there's already a standard way to report (recoverable) kernel bugs --
the WARN() family of macros. WARNs are noisier and harder to miss, and
existing test systems already know to look for them in dmesg or via
/proc/sys/kernel/tainted.
Therefore, call WARN() when an algorithm fails its self-tests.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'certs')
0 files changed, 0 insertions, 0 deletions