summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2011-01-18 10:13:13 +0100
committerJames Bottomley <James.Bottomley@suse.de>2011-02-12 10:33:37 -0600
commit79775567e0439ca47eb9f501e52c4b713d44cf89 (patch)
tree1cb890e0a061b007ae10bd281a60ada60a6d2bb1 /block
parent751b2a7d623ead9e55f751a6087efeab454b5659 (diff)
downloadlwn-79775567e0439ca47eb9f501e52c4b713d44cf89.tar.gz
lwn-79775567e0439ca47eb9f501e52c4b713d44cf89.zip
[SCSI] block: improve detail in I/O error messages
Classify severity of I/O errors for target, nexus, and transport errors. Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Hannes Reinecke <hare@suse.de> Acked-by: Jens Axboe <jaxboe@fusionio.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'block')
-rw-r--r--block/blk-core.c23
1 files changed, 20 insertions, 3 deletions
diff --git a/block/blk-core.c b/block/blk-core.c
index 2f4002f79a24..b3cf121f1de9 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2044,9 +2044,26 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
if (error && req->cmd_type == REQ_TYPE_FS &&
!(req->cmd_flags & REQ_QUIET)) {
- printk(KERN_ERR "end_request: I/O error, dev %s, sector %llu\n",
- req->rq_disk ? req->rq_disk->disk_name : "?",
- (unsigned long long)blk_rq_pos(req));
+ char *error_type;
+
+ switch (error) {
+ case -ENOLINK:
+ error_type = "recoverable transport";
+ break;
+ case -EREMOTEIO:
+ error_type = "critical target";
+ break;
+ case -EBADE:
+ error_type = "critical nexus";
+ break;
+ case -EIO:
+ default:
+ error_type = "I/O";
+ break;
+ }
+ printk(KERN_ERR "end_request: %s error, dev %s, sector %llu\n",
+ error_type, req->rq_disk ? req->rq_disk->disk_name : "?",
+ (unsigned long long)blk_rq_pos(req));
}
blk_account_io_completion(req, nr_bytes);