diff options
| author | Jens Axboe <axboe@kernel.dk> | 2022-05-18 16:32:00 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-05-18 16:32:00 -0600 |
| commit | 1305e2c9d91a9f64c0eb5d4e1b5bc29930f3b834 (patch) | |
| tree | eb19ac04fbc9357562030df99f72990c91956be6 /block | |
| parent | 5a011f889b4832aa80c2a872a5aade5c48d2756f (diff) | |
| download | lwn-1305e2c9d91a9f64c0eb5d4e1b5bc29930f3b834.tar.gz lwn-1305e2c9d91a9f64c0eb5d4e1b5bc29930f3b834.zip | |
blk-cgroup: delete rcu_read_lock_held() WARN_ON_ONCE()
A previous commit got rid of unnecessary rcu_read_lock() inside the
IRQ disabling queue_lock, but this debug statement was left. It's now
firing since we are indeed not inside a RCU read lock, but we don't
need to be as we're still preempt safe.
Get rid of the check, as we have a lockdep assert for holding the
queue lock right after it anyway.
Link: https://lore.kernel.org/linux-block/46253c48-81cb-0787-20ad-9133afdd9e21@samsung.com/
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: 77c570a1ea85 ("blk-cgroup: Remove unnecessary rcu_read_lock/unlock()")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-cgroup.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 0676cf7a41b5..40161a3f68d0 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -298,7 +298,6 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg, struct blkcg_gq *blkg; int i, ret; - WARN_ON_ONCE(!rcu_read_lock_held()); lockdep_assert_held(&q->queue_lock); /* request_queue is dying, do not create/recreate a blkg */ |