diff options
| author | Jens Axboe <jaxboe@fusionio.com> | 2011-04-21 19:28:35 +0200 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2011-04-21 19:28:35 +0200 |
| commit | 3aa72873ffdcc2f7919743efbbefc351ec73f5cb (patch) | |
| tree | f159c777a489c6ac3721ba1f1cadbe2d86b19fa5 /block | |
| parent | 584f79046780e10cb24367a691f8c28398a00e84 (diff) | |
| download | lwn-3aa72873ffdcc2f7919743efbbefc351ec73f5cb.tar.gz lwn-3aa72873ffdcc2f7919743efbbefc351ec73f5cb.zip | |
elevator: check for ELEVATOR_INSERT_SORT_MERGE in !elvpriv case too
The sort insert is the one that goes to the IO scheduler. With
the SORT_MERGE addition, we could bypass IO scheduler setup
but still ask the IO scheduler to insert the request. This would
cause an oops on switching IO schedulers through the sysfs
interface, unless the disk just happened to be idle while it
occured.
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/elevator.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/block/elevator.c b/block/elevator.c index 6f6abc08bb56..45ca1e34f582 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -671,7 +671,8 @@ void __elv_add_request(struct request_queue *q, struct request *rq, int where) q->boundary_rq = rq; } } else if (!(rq->cmd_flags & REQ_ELVPRIV) && - where == ELEVATOR_INSERT_SORT) + (where == ELEVATOR_INSERT_SORT || + where == ELEVATOR_INSERT_SORT_MERGE)) where = ELEVATOR_INSERT_BACK; switch (where) { |