diff options
| author | Tony Battersby <tonyb@cybernetics.com> | 2015-02-11 11:32:30 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-06 14:52:56 -0800 |
| commit | 7da36aa36365915732662a45f808c221d1a6c111 (patch) | |
| tree | f3653dcbe264ac551024a7977ab05338a1018b8e /block | |
| parent | d2c8636c468a28c2398e21debdcce56bddeea309 (diff) | |
| download | lwn-7da36aa36365915732662a45f808c221d1a6c111.tar.gz lwn-7da36aa36365915732662a45f808c221d1a6c111.zip | |
blk-mq: fix double-free in error path
commit 564e559f2baf6a868768d0cac286980b3cfd6e30 upstream.
If the allocation of bt->bs fails, then bt->map can be freed twice, once
in blk_mq_init_bitmap_tags() -> bt_alloc(), and once in
blk_mq_init_bitmap_tags() -> bt_free(). Fix by setting the pointer to
NULL after the first free.
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-mq-tag.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index ff18dab6b585..702ae29b8d90 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -500,6 +500,7 @@ static int bt_alloc(struct blk_mq_bitmap_tags *bt, unsigned int depth, bt->bs = kzalloc(BT_WAIT_QUEUES * sizeof(*bt->bs), GFP_KERNEL); if (!bt->bs) { kfree(bt->map); + bt->map = NULL; return -ENOMEM; } |