summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorDavidlohr Bueso <davidlohr@hp.com>2013-09-11 14:25:01 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-09-11 15:59:18 -0700
commitaa054bc93743ecce3a27f1655d59674dabc71a54 (patch)
treeef4a3d6042ce1ae5554cea6c29e2aca6c230f5dd /block
parent27a7c642174eaec627f6a3a254035bf8abd02c5e (diff)
downloadlwn-aa054bc93743ecce3a27f1655d59674dabc71a54.tar.gz
lwn-aa054bc93743ecce3a27f1655d59674dabc71a54.zip
partitions/efi: compare first and last usable LBAs
When verifying GPT header integrity, make sure that first usable LBA is smaller than last usable LBA. Signed-off-by: Davidlohr Bueso <davidlohr@hp.com> Reviewed-by: Karel Zak <kzak@redhat.com> Acked-by: Matt Fleming <matt.fleming@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'block')
-rw-r--r--block/partitions/efi.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/block/partitions/efi.c b/block/partitions/efi.c
index b028af688361..de9f9bfa24bc 100644
--- a/block/partitions/efi.c
+++ b/block/partitions/efi.c
@@ -410,7 +410,12 @@ static int is_gpt_valid(struct parsed_partitions *state, u64 lba,
(unsigned long long)lastlba);
goto fail;
}
-
+ if (le64_to_cpu((*gpt)->last_usable_lba) < le64_to_cpu((*gpt)->first_usable_lba)) {
+ pr_debug("GPT: last_usable_lba incorrect: %lld > %lld\n",
+ (unsigned long long)le64_to_cpu((*gpt)->last_usable_lba),
+ (unsigned long long)le64_to_cpu((*gpt)->first_usable_lba));
+ goto fail;
+ }
/* Check that sizeof_partition_entry has the correct value */
if (le32_to_cpu((*gpt)->sizeof_partition_entry) != sizeof(gpt_entry)) {
pr_debug("GUID Partitition Entry Size check failed.\n");