diff options
| author | David Kozub <zub@linux.fjfi.cvut.cz> | 2019-02-14 01:15:59 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-04-06 11:09:12 -0600 |
| commit | 7d9b62ae2a7db6dfa218999b7dd65517a6f9cfb7 (patch) | |
| tree | a5dca859d3fad361a03455da1bac3eb71eed04eb /block/sed-opal.c | |
| parent | e8b2922459cf15140ab8cc1f92b6861674fff1a3 (diff) | |
| download | lwn-7d9b62ae2a7db6dfa218999b7dd65517a6f9cfb7.tar.gz lwn-7d9b62ae2a7db6dfa218999b7dd65517a6f9cfb7.zip | |
block: sed-opal: unify error handling of responses
response_get_{string,u64} include error handling for argument resp being
NULL but response_get_token does not handle this.
Make all three of response_get_{string,u64,token} handle NULL resp in
the same way.
Co-authored-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/sed-opal.c')
| -rw-r--r-- | block/sed-opal.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/block/sed-opal.c b/block/sed-opal.c index 0348fb896a5d..3f368b14efd9 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -696,6 +696,11 @@ static const struct opal_resp_tok *response_get_token( { const struct opal_resp_tok *tok; + if (!resp) { + pr_debug("Response is NULL\n"); + return ERR_PTR(-EINVAL); + } + if (n >= resp->num) { pr_debug("Token number doesn't exist: %d, resp: %d\n", n, resp->num); |