summaryrefslogtreecommitdiff
path: root/block/fops.c
diff options
context:
space:
mode:
authorVernon Lovejoy <vlovejoy@redhat.com>2023-05-12 12:42:32 +0200
committerJosh Poimboeuf <jpoimboe@kernel.org>2023-05-16 06:31:04 -0700
commit2e4be0d011f21593c6b316806779ba1eba2cd7e0 (patch)
treebfa3134ea8c62e20c528d4ecf398c20a392c60dd /block/fops.c
parentf7ba52f302fdc392e0047f38e50841483d997144 (diff)
downloadlwn-2e4be0d011f21593c6b316806779ba1eba2cd7e0.tar.gz
lwn-2e4be0d011f21593c6b316806779ba1eba2cd7e0.zip
x86/show_trace_log_lvl: Ensure stack pointer is aligned, again
The commit e335bb51cc15 ("x86/unwind: Ensure stack pointer is aligned") tried to align the stack pointer in show_trace_log_lvl(), otherwise the "stack < stack_info.end" check can't guarantee that the last read does not go past the end of the stack. However, we have the same problem with the initial value of the stack pointer, it can also be unaligned. So without this patch this trivial kernel module #include <linux/module.h> static int init(void) { asm volatile("sub $0x4,%rsp"); dump_stack(); asm volatile("add $0x4,%rsp"); return -EAGAIN; } module_init(init); MODULE_LICENSE("GPL"); crashes the kernel. Fixes: e335bb51cc15 ("x86/unwind: Ensure stack pointer is aligned") Signed-off-by: Vernon Lovejoy <vlovejoy@redhat.com> Signed-off-by: Oleg Nesterov <oleg@redhat.com> Link: https://lore.kernel.org/r/20230512104232.GA10227@redhat.com Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Diffstat (limited to 'block/fops.c')
0 files changed, 0 insertions, 0 deletions