diff options
| author | Christoph Hellwig <hch@lst.de> | 2024-05-03 10:10:42 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2024-05-03 09:05:11 -0600 |
| commit | 0c12028aec837f5a002009bbf68d179d506510e8 (patch) | |
| tree | 2022ff8ffd9092f7d48f76287b58cfca87f593d2 /block/fops.c | |
| parent | a4217c6740dc64a3eb6815868a9260825e8c68c6 (diff) | |
| download | lwn-0c12028aec837f5a002009bbf68d179d506510e8.tar.gz lwn-0c12028aec837f5a002009bbf68d179d506510e8.zip | |
block: refine the EOF check in blkdev_iomap_begin
blkdev_iomap_begin rounds down the offset to the logical block size
before stashing it in iomap->offset and checking that it still is
inside the inode size.
Check the i_size check to the raw pos value so that we don't try a
zero size write if iter->pos is unaligned.
Fixes: 487c607df790 ("block: use iomap for writes to block devices")
Reported-by: syzbot+0a3683a0a6fecf909244@syzkaller.appspotmail.com
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: syzbot+0a3683a0a6fecf909244@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20240503081042.2078062-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/fops.c')
| -rw-r--r-- | block/fops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/fops.c b/block/fops.c index c091ea43bca3..5159ef3a1948 100644 --- a/block/fops.c +++ b/block/fops.c @@ -385,7 +385,7 @@ static int blkdev_iomap_begin(struct inode *inode, loff_t offset, loff_t length, iomap->bdev = bdev; iomap->offset = ALIGN_DOWN(offset, bdev_logical_block_size(bdev)); - if (iomap->offset >= isize) + if (offset >= isize) return -EIO; iomap->type = IOMAP_MAPPED; iomap->addr = iomap->offset; |