diff options
author | Ming Lei <ming.lei@redhat.com> | 2019-09-26 06:23:54 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-09-26 00:45:05 -0600 |
commit | 284b94be1925dbe035ce5218d8b5c197321262c7 (patch) | |
tree | cf92c78c0064fa7b31b0d03baf266a18ed21f5e7 /block/elevator.c | |
parent | f41def397161053eb0d3ed6861ef65985efbf293 (diff) | |
download | lwn-284b94be1925dbe035ce5218d8b5c197321262c7.tar.gz lwn-284b94be1925dbe035ce5218d8b5c197321262c7.zip |
blk-mq: move lockdep_assert_held() into elevator_exit
Commit c48dac137a62 ("block: don't hold q->sysfs_lock in elevator_init_mq")
removes q->sysfs_lock from elevator_init_mq(), but forgot to deal with
lockdep_assert_held() called in blk_mq_sched_free_requests() which is
run in failure path of elevator_init_mq().
blk_mq_sched_free_requests() is called in the following 3 functions:
elevator_init_mq()
elevator_exit()
blk_cleanup_queue()
In blk_cleanup_queue(), blk_mq_sched_free_requests() is followed exactly
by 'mutex_lock(&q->sysfs_lock)'.
So moving the lockdep_assert_held() from blk_mq_sched_free_requests()
into elevator_exit() for fixing the report by syzbot.
Reported-by: syzbot+da3b7677bb913dc1b737@syzkaller.appspotmail.com
Fixed: c48dac137a62 ("block: don't hold q->sysfs_lock in elevator_init_mq")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/elevator.c')
0 files changed, 0 insertions, 0 deletions