diff options
| author | Namhyung Kim <namhyung@gmail.com> | 2011-05-24 10:23:22 +0200 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2011-05-24 10:23:22 +0200 |
| commit | 20359f27e8ff115f7cddf3da5b3a6cdcca2e650d (patch) | |
| tree | b87c86545f68c5c660f3aeaf4cf3e366fa7db668 /block/cfq-iosched.c | |
| parent | 229836bd63c5413a4f8eed93d610b432be141e9b (diff) | |
| download | lwn-20359f27e8ff115f7cddf3da5b3a6cdcca2e650d.tar.gz lwn-20359f27e8ff115f7cddf3da5b3a6cdcca2e650d.zip | |
cfq-iosched: remove unused 'group_changed' in cfq_service_tree_add()
The 'group_changed' variable is initialized to 0 and never changed, so
checking the variable is meaningless.
It is a leftover from 0bbfeb832042 ("cfq-iosched: Always provide group
iosolation."). Let's get rid of it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Justin TerAvest <teravest@google.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'block/cfq-iosched.c')
| -rw-r--r-- | block/cfq-iosched.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 7ffceddee420..6dd2179cf1a4 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1279,7 +1279,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, struct cfq_rb_root *service_tree; int left; int new_cfqq = 1; - int group_changed = 0; service_tree = service_tree_for(cfqq->cfqg, cfqq_prio(cfqq), cfqq_type(cfqq)); @@ -1350,7 +1349,7 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, rb_link_node(&cfqq->rb_node, parent, p); rb_insert_color(&cfqq->rb_node, &service_tree->rb); service_tree->count++; - if ((add_front || !new_cfqq) && !group_changed) + if (add_front || !new_cfqq) return; cfq_group_notify_queue_add(cfqd, cfqq->cfqg); } |