diff options
| author | Jens Axboe <axboe@fb.com> | 2016-10-27 09:49:19 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-10-27 19:13:56 -0600 |
| commit | 7dd2fb6877b601a0b9c7284534ca4916cd7ac4bd (patch) | |
| tree | 47535b50e12507af176a503ebb364938c2fa3651 /block/blk-mq.c | |
| parent | ff26956875c2f05e12ecec9938411a2c7dfc767d (diff) | |
| download | lwn-7dd2fb6877b601a0b9c7284534ca4916cd7ac4bd.tar.gz lwn-7dd2fb6877b601a0b9c7284534ca4916cd7ac4bd.zip | |
blk-mq: update hardware and software queues for sleeping alloc
If we end up sleeping due to running out of requests, we should
update the hardware and software queues in the map ctx structure.
Otherwise we could end up having rq->mq_ctx point to the pre-sleep
context, and risk corrupting ctx->rq_list since we'll be
grabbing the wrong lock when inserting the request.
Reported-by: Dave Jones <davej@codemonkey.org.uk>
Reported-by: Chris Mason <clm@fb.com>
Tested-by: Chris Mason <clm@fb.com>
Fixes: 63581af3f31e ("blk-mq: remove non-blocking pass in blk_mq_map_request")
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-mq.c')
| -rw-r--r-- | block/blk-mq.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index ddc2eed64771..f3d27a6dee09 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1217,9 +1217,9 @@ static struct request *blk_mq_map_request(struct request_queue *q, blk_mq_set_alloc_data(&alloc_data, q, 0, ctx, hctx); rq = __blk_mq_alloc_request(&alloc_data, op, op_flags); - hctx->queued++; - data->hctx = hctx; - data->ctx = ctx; + data->hctx = alloc_data.hctx; + data->ctx = alloc_data.ctx; + data->hctx->queued++; return rq; } |