diff options
| author | Ming Lei <ming.lei@redhat.com> | 2020-08-10 11:59:50 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-08-11 13:53:32 -0600 |
| commit | c1e2b8422bf946c80e832cee22b3399634f87a2c (patch) | |
| tree | b2f0e952a1eb443f310044dd5c7962124d6ad1c7 /block/blk-flush.c | |
| parent | fe6a8fc5ed2f0081f17375ae2005718522c392c6 (diff) | |
| download | lwn-c1e2b8422bf946c80e832cee22b3399634f87a2c.tar.gz lwn-c1e2b8422bf946c80e832cee22b3399634f87a2c.zip | |
block: fix double account of flush request's driver tag
In case of none scheduler, we share data request's driver tag for
flush request, so have to mark the flush request as INFLIGHT for
avoiding double account of this driver tag.
Fixes: 568f27006577 ("blk-mq: centralise related handling into blk_mq_get_driver_tag")
Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Tested-by: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-flush.c')
| -rw-r--r-- | block/blk-flush.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/block/blk-flush.c b/block/blk-flush.c index 6e1543c10493..53abb5c73d99 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -308,9 +308,16 @@ static void blk_kick_flush(struct request_queue *q, struct blk_flush_queue *fq, flush_rq->mq_ctx = first_rq->mq_ctx; flush_rq->mq_hctx = first_rq->mq_hctx; - if (!q->elevator) + if (!q->elevator) { flush_rq->tag = first_rq->tag; - else + + /* + * We borrow data request's driver tag, so have to mark + * this flush request as INFLIGHT for avoiding double + * account of this driver tag + */ + flush_rq->rq_flags |= RQF_MQ_INFLIGHT; + } else flush_rq->internal_tag = first_rq->internal_tag; flush_rq->cmd_flags = REQ_OP_FLUSH | REQ_PREFLUSH; |