diff options
| author | Christoph Hellwig <hch@lst.de> | 2021-07-27 07:56:46 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-08-02 13:37:28 -0600 |
| commit | 503469b5b30f76169c6302d1469e69a2fb67faf9 (patch) | |
| tree | 23cb54b05c6112ab49a75492bd501d690ac3ed1c /block/bio-integrity.c | |
| parent | 8aec120a9ca80c14ce002505cea1e1639f8e9ea5 (diff) | |
| download | lwn-503469b5b30f76169c6302d1469e69a2fb67faf9.tar.gz lwn-503469b5b30f76169c6302d1469e69a2fb67faf9.zip | |
block: use bvec_kmap_local in bio_integrity_process
Using local kmaps slightly reduces the chances to stray writes, and
the bvec interface cleans up the code a little bit.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20210727055646.118787-16-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/bio-integrity.c')
| -rw-r--r-- | block/bio-integrity.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/block/bio-integrity.c b/block/bio-integrity.c index 4b4eb8964a6f..8f54d49dc500 100644 --- a/block/bio-integrity.c +++ b/block/bio-integrity.c @@ -172,18 +172,16 @@ static blk_status_t bio_integrity_process(struct bio *bio, iter.prot_buf = prot_buf; __bio_for_each_segment(bv, bio, bviter, *proc_iter) { - void *kaddr = kmap_atomic(bv.bv_page); + void *kaddr = bvec_kmap_local(&bv); - iter.data_buf = kaddr + bv.bv_offset; + iter.data_buf = kaddr; iter.data_size = bv.bv_len; - ret = proc_fn(&iter); - if (ret) { - kunmap_atomic(kaddr); - return ret; - } + kunmap_local(kaddr); + + if (ret) + break; - kunmap_atomic(kaddr); } return ret; } |