diff options
| author | Andi Kleen <ak@suse.de> | 2005-12-16 11:08:55 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-12-16 11:25:25 -0800 |
| commit | 42f3ab42875a52af7e711803bfb8d8d7cca84c1c (patch) | |
| tree | cb07374ba0f88582339a8f214ef8db81e4ee1b85 /arch | |
| parent | 52f975ea21e28871a371c2d941e13d64c9f8cd66 (diff) | |
| download | lwn-42f3ab42875a52af7e711803bfb8d8d7cca84c1c.tar.gz lwn-42f3ab42875a52af7e711803bfb8d8d7cca84c1c.zip | |
[PATCH] PCI: Fix dumb bug in mmconfig fix
Use correct address when referencing mmconfig aperture while checking
for broken MCFG. This was a typo when porting the code from 64bit to
32bit. It caused oopses at boot on some ThinkPads.
Should definitely go into 2.6.15.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/i386/pci/mmconfig.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/i386/pci/mmconfig.c b/arch/i386/pci/mmconfig.c index 70a9cc132cf7..4bb4d4b0f73a 100644 --- a/arch/i386/pci/mmconfig.c +++ b/arch/i386/pci/mmconfig.c @@ -155,7 +155,7 @@ static __init void unreachable_devices(void) addr = get_base_addr(0, 0, PCI_DEVFN(i, 0)); if (addr != 0) pci_exp_set_dev_base(addr, 0, PCI_DEVFN(i, 0)); - if (addr == 0 || readl((u32 __iomem *)addr) != val1) + if (addr == 0 || readl((u32 __iomem *)mmcfg_virt_addr) != val1) set_bit(i, fallback_slots); spin_unlock_irqrestore(&pci_config_lock, flags); } |