diff options
| author | Michael Neuling <michael.neuling@au1.ibm.com> | 2013-04-24 00:30:09 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-07 19:51:52 -0700 |
| commit | 59973aa09eaac7eb849badd597453ec0b4230ebf (patch) | |
| tree | 71b0552aed844943077c6f5bed6409ecb50d5676 /arch | |
| parent | 635b15ddf03123c602a6bfb0505c01d0a0fb46a4 (diff) | |
| download | lwn-59973aa09eaac7eb849badd597453ec0b4230ebf.tar.gz lwn-59973aa09eaac7eb849badd597453ec0b4230ebf.zip | |
powerpc: Add isync to copy_and_flush
commit 29ce3c5073057991217916abc25628e906911757 upstream.
In __after_prom_start we copy the kernel down to zero in two calls to
copy_and_flush. After the first call (copy from 0 to copy_to_here:)
we jump to the newly copied code soon after.
Unfortunately there's no isync between the copy of this code and the
jump to it. Hence it's possible that stale instructions could still be
in the icache or pipeline before we branch to it.
We've seen this on real machines and it's results in no console output
after:
calling quiesce...
returning from prom_init
The below adds an isync to ensure that the copy and flushing has
completed before any branching to the new instructions occurs.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/powerpc/kernel/head_64.S | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S index 9e07bd038dda..1a3607b96635 100644 --- a/arch/powerpc/kernel/head_64.S +++ b/arch/powerpc/kernel/head_64.S @@ -489,6 +489,7 @@ _GLOBAL(copy_and_flush) sync addi r5,r5,8 addi r6,r6,8 + isync blr .align 8 |