diff options
| author | Dirk Müller <dmueller@suse.com> | 2015-10-01 13:43:42 +0200 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-10-27 22:13:08 -0400 |
| commit | 1e4f2890f92a32b41fdae434cee45eb93d239ad4 (patch) | |
| tree | c773ab1ef31664b7b77477623e52c89241f8e83f /arch | |
| parent | 7cb9685d817e262c8dce4e3bd369f243bc6961f8 (diff) | |
| download | lwn-1e4f2890f92a32b41fdae434cee45eb93d239ad4.tar.gz lwn-1e4f2890f92a32b41fdae434cee45eb93d239ad4.zip | |
Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS
[ Upstream commit d2922422c48df93f3edff7d872ee4f3191fefb08 ]
The cpu feature flags are not ever going to change, so warning
everytime can cause a lot of kernel log spam
(in our case more than 10GB/hour).
The warning seems to only occur when nested virtualization is
enabled, so it's probably triggered by a KVM bug. This is a
sensible and safe change anyway, and the KVM bug fix might not
be suitable for stable releases anyway.
Cc: stable@vger.kernel.org
Signed-off-by: Dirk Mueller <dmueller@suse.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/kvm/svm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index b83bff87408f..f98baebfa9a7 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -512,7 +512,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu) struct vcpu_svm *svm = to_svm(vcpu); if (svm->vmcb->control.next_rip != 0) { - WARN_ON(!static_cpu_has(X86_FEATURE_NRIPS)); + WARN_ON_ONCE(!static_cpu_has(X86_FEATURE_NRIPS)); svm->next_rip = svm->vmcb->control.next_rip; } |