diff options
| author | Jason Baron <jbaron@redhat.com> | 2010-10-28 11:20:27 -0400 |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2010-10-29 16:42:58 -0700 |
| commit | 404ba5d7bb958d3d788bdaa0debc0bdf60f13ffe (patch) | |
| tree | 0605498ad8f207de58bfefa5b4b62ad79f91be8f /arch | |
| parent | 5c1eb08936693cd78c71164c8bea0b086ae72c67 (diff) | |
| download | lwn-404ba5d7bb958d3d788bdaa0debc0bdf60f13ffe.tar.gz lwn-404ba5d7bb958d3d788bdaa0debc0bdf60f13ffe.zip | |
x86, alternative: Call stop_machine_text_poke() on all cpus
Currently, text_poke_smp() passes a NULL as the third argument to
__stop_machine(), which will only run stop_machine_text_poke()
on 1 cpu. Change NULL -> cpu_online_mask, as stop_machine_text_poke()
is intended to be run on all cpus.
I actually didn't notice any problems with stop_machine_text_poke()
only being called on 1 cpu, but found this via code inspection.
Signed-off-by: Jason Baron <jbaron@redhat.com>
LKML-Reference: <20101028152026.GB2875@redhat.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/kernel/alternative.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index a36bb90aef53..5ceeca382820 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -638,7 +638,7 @@ void *__kprobes text_poke_smp(void *addr, const void *opcode, size_t len) atomic_set(&stop_machine_first, 1); wrote_text = 0; /* Use __stop_machine() because the caller already got online_cpus. */ - __stop_machine(stop_machine_text_poke, (void *)&tpp, NULL); + __stop_machine(stop_machine_text_poke, (void *)&tpp, cpu_online_mask); return addr; } |