diff options
| author | Behan Webster <behanw@converseincode.com> | 2014-09-24 01:06:46 +0100 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-01-27 09:56:35 +0100 |
| commit | 94738c4f7c1cfefee481a3d3e5c8f78de2c9fd41 (patch) | |
| tree | f2acacf035c31e69aeff9ec2adcfbfac8a8e8e1d /arch | |
| parent | 769954681990aa9ff4c50fb4a3b953894bf03345 (diff) | |
| download | lwn-94738c4f7c1cfefee481a3d3e5c8f78de2c9fd41.tar.gz lwn-94738c4f7c1cfefee481a3d3e5c8f78de2c9fd41.zip | |
ARM: 8158/1: LLVMLinux: use static inline in ARM ftrace.h
commit aeea3592a13bf12861943e44fc48f1f270941f8d upstream.
With compilers which follow the C99 standard (like modern versions of gcc and
clang), "extern inline" does the wrong thing (emits code for an externally
linkable version of the inline function). In this case using static inline
and removing the NULL version of return_address in return_address.c does
the right thing.
Signed-off-by: Behan Webster <behanw@converseincode.com>
Reviewed-by: Mark Charlebois <charlebm@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arm/include/asm/ftrace.h | 2 | ||||
| -rw-r--r-- | arch/arm/kernel/return_address.c | 5 |
2 files changed, 1 insertions, 6 deletions
diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h index f89515adac60..2bb8cac28b9e 100644 --- a/arch/arm/include/asm/ftrace.h +++ b/arch/arm/include/asm/ftrace.h @@ -45,7 +45,7 @@ void *return_address(unsigned int); #else -extern inline void *return_address(unsigned int level) +static inline void *return_address(unsigned int level) { return NULL; } diff --git a/arch/arm/kernel/return_address.c b/arch/arm/kernel/return_address.c index fafedd86885d..f6aa84d5b93c 100644 --- a/arch/arm/kernel/return_address.c +++ b/arch/arm/kernel/return_address.c @@ -63,11 +63,6 @@ void *return_address(unsigned int level) #warning "TODO: return_address should use unwind tables" #endif -void *return_address(unsigned int level) -{ - return NULL; -} - #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) / else */ EXPORT_SYMBOL_GPL(return_address); |