diff options
| author | David S. Miller <davem@davemloft.net> | 2011-03-09 13:00:47 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-21 14:32:39 -0700 |
| commit | 247a80437d061450c5e9f371547aef4e34baec16 (patch) | |
| tree | ad50ccfa630cc3f68c56e8295bdfeca6e06e3f6b /arch | |
| parent | 26a92fe2e4418a73b554c9e335840d424a2a4136 (diff) | |
| download | lwn-247a80437d061450c5e9f371547aef4e34baec16.tar.gz lwn-247a80437d061450c5e9f371547aef4e34baec16.zip | |
sparc32: Fix might-be-used-uninitialized warning in do_sparc_fault().
[ Upstream commit c816be7b5f24585baa9eba1f2413935f771d6ad6 ]
When we try to handle vmalloc faults, we can take a code
path which uses "code" before we actually set it.
Amusingly gcc-3.3 notices this yet gcc-4.x does not.
Reported-by: Bob Breuer <breuerr@mc.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/sparc/mm/fault_32.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/sparc/mm/fault_32.c b/arch/sparc/mm/fault_32.c index 5b836f5aea90..b10ac4d62378 100644 --- a/arch/sparc/mm/fault_32.c +++ b/arch/sparc/mm/fault_32.c @@ -240,11 +240,10 @@ asmlinkage void do_sparc_fault(struct pt_regs *regs, int text_fault, int write, * only copy the information from the master page table, * nothing more. */ + code = SEGV_MAPERR; if (!ARCH_SUN4C && address >= TASK_SIZE) goto vmalloc_fault; - code = SEGV_MAPERR; - /* * If we're in an interrupt or have no user * context, we must not take the fault.. |