diff options
| author | Tsuneo.Yoshioka@f-secure.com <Tsuneo.Yoshioka@f-secure.com> | 2005-09-12 18:49:24 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-12 10:49:57 -0700 |
| commit | 83b942bd3437d84d6ddf582477120b6b86369052 (patch) | |
| tree | 75fcfc6d7f175cd35911bf93713d45a82c67a3fc /arch/x86_64/ia32/sys_ia32.c | |
| parent | 9acf23c42b13d682abbd5db1d293c7a77ae54b61 (diff) | |
| download | lwn-83b942bd3437d84d6ddf582477120b6b86369052.tar.gz lwn-83b942bd3437d84d6ddf582477120b6b86369052.zip | |
[PATCH] x86-64: Fix 32bit sendfile
If we use 64bit kernel on ia64/x86_64/s390 architecture, and we run
32bit binary on 32bit compatibility mode, sendfile system call seems be
not set offset argument.
This is because sendfile's return value is not zero but the code regards
the result by return value is zero or not.
This problem will be affect to ia64/x86_64/s390 and not affect to other
architecture does not affect other architecture (mips/parisc/ppc64/sparc64).
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/x86_64/ia32/sys_ia32.c')
| -rw-r--r-- | arch/x86_64/ia32/sys_ia32.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86_64/ia32/sys_ia32.c b/arch/x86_64/ia32/sys_ia32.c index 04d80406ce4f..5389df610e78 100644 --- a/arch/x86_64/ia32/sys_ia32.c +++ b/arch/x86_64/ia32/sys_ia32.c @@ -751,7 +751,7 @@ sys32_sendfile(int out_fd, int in_fd, compat_off_t __user *offset, s32 count) ret = sys_sendfile(out_fd, in_fd, offset ? &of : NULL, count); set_fs(old_fs); - if (!ret && offset && put_user(of, offset)) + if (offset && put_user(of, offset)) return -EFAULT; return ret; |