diff options
| author | Keith Busch <keith.busch@intel.com> | 2016-04-27 14:22:32 -0600 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2016-04-28 09:53:06 +0200 |
| commit | 1bdb8970392a68489b469c3a330a1adb5ef61beb (patch) | |
| tree | 11025813d263bc88cbafe5e0d892e2dac11bddbf /arch/x86 | |
| parent | e16d8a6cbb499c5c8bfe9330d3351b649bded4af (diff) | |
| download | lwn-1bdb8970392a68489b469c3a330a1adb5ef61beb.tar.gz lwn-1bdb8970392a68489b469c3a330a1adb5ef61beb.zip | |
x86/apic: Handle zero vector gracefully in clear_vector_irq()
If x86_vector_alloc_irq() fails x86_vector_free_irqs() is invoked to cleanup
the already allocated vectors. This subsequently calls clear_vector_irq().
The failed irq has no vector assigned, which triggers the BUG_ON(!vector) in
clear_vector_irq().
We cannot suppress the call to x86_vector_free_irqs() for the failed
interrupt, because the other data related to this irq must be cleaned up as
well. So calling clear_vector_irq() with vector == 0 is legitimate.
Remove the BUG_ON and return if vector is zero,
[ tglx: Massaged changelog ]
Fixes: b5dc8e6c21e7 "x86/irq: Use hierarchical irqdomain to manage CPU interrupt vectors"
Signed-off-by: Keith Busch <keith.busch@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86')
| -rw-r--r-- | arch/x86/kernel/apic/vector.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c index ad59d70bcb1a..ef495511f019 100644 --- a/arch/x86/kernel/apic/vector.c +++ b/arch/x86/kernel/apic/vector.c @@ -256,7 +256,8 @@ static void clear_irq_vector(int irq, struct apic_chip_data *data) struct irq_desc *desc; int cpu, vector; - BUG_ON(!data->cfg.vector); + if (!data->cfg.vector) + return; vector = data->cfg.vector; for_each_cpu_and(cpu, data->domain, cpu_online_mask) |