diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2013-10-17 16:50:47 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2013-10-31 11:31:19 +0100 |
| commit | c67a04cb9aee0d6c0b27ab8f3f68668ed6b72897 (patch) | |
| tree | 2c044ca0265cded83f7e1ef0958a55df31f08867 /arch/x86/kvm/x86.c | |
| parent | 46c34cb059d519601fb567b55cf45c300fea2928 (diff) | |
| download | lwn-c67a04cb9aee0d6c0b27ab8f3f68668ed6b72897.tar.gz lwn-c67a04cb9aee0d6c0b27ab8f3f68668ed6b72897.zip | |
KVM: x86: fix KVM_SET_XCRS loop
The loop was always using 0 as the index. This means that
any rubbish after the first element of the array went undetected.
It seems reasonable to assume that no KVM userspace did that.
Reviewed-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86/kvm/x86.c')
| -rw-r--r-- | arch/x86/kvm/x86.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 296154956399..6d16fc530246 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3064,9 +3064,9 @@ static int kvm_vcpu_ioctl_x86_set_xcrs(struct kvm_vcpu *vcpu, for (i = 0; i < guest_xcrs->nr_xcrs; i++) /* Only support XCR0 currently */ - if (guest_xcrs->xcrs[0].xcr == XCR_XFEATURE_ENABLED_MASK) { + if (guest_xcrs->xcrs[i].xcr == XCR_XFEATURE_ENABLED_MASK) { r = __kvm_set_xcr(vcpu, XCR_XFEATURE_ENABLED_MASK, - guest_xcrs->xcrs[0].value); + guest_xcrs->xcrs[i].value); break; } if (r) |