diff options
| author | Sean Christopherson <seanjc@google.com> | 2024-08-02 11:19:28 -0700 |
|---|---|---|
| committer | Sean Christopherson <seanjc@google.com> | 2024-08-22 12:06:29 -0700 |
| commit | aaecae7b6a2b19a874a7df0d474f44f3a5b5a74e (patch) | |
| tree | 6e82f5642631f571718ad9725a639761e656c963 /arch/x86/kvm/vmx/vmx.c | |
| parent | b58b808cbe93e8abe936b285ae534c9927789242 (diff) | |
| download | lwn-aaecae7b6a2b19a874a7df0d474f44f3a5b5a74e.tar.gz lwn-aaecae7b6a2b19a874a7df0d474f44f3a5b5a74e.zip | |
KVM: x86: Rename KVM_MSR_RET_INVALID to KVM_MSR_RET_UNSUPPORTED
Rename the "INVALID" internal MSR error return code to "UNSUPPORTED" to
try and make it more clear that access was denied because the MSR itself
is unsupported/unknown. "INVALID" is too ambiguous, as it could just as
easily mean the value for WRMSR as invalid.
Avoid UNKNOWN and UNIMPLEMENTED, as the error code is used for MSRs that
_are_ actually implemented by KVM, e.g. if the MSR is unsupported because
an associated feature flag is not present in guest CPUID.
Opportunistically beef up the comments for the internal MSR error codes.
Link: https://lore.kernel.org/r/20240802181935.292540-4-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86/kvm/vmx/vmx.c')
| -rw-r--r-- | arch/x86/kvm/vmx/vmx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index f18c2d8c7476..e5b253e4d421 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2006,7 +2006,7 @@ int vmx_get_msr_feature(struct kvm_msr_entry *msr) return 1; return vmx_get_vmx_msr(&vmcs_config.nested, msr->index, &msr->data); default: - return KVM_MSR_RET_INVALID; + return KVM_MSR_RET_UNSUPPORTED; } } |