diff options
author | Alexey Kardashevskiy <aik@amd.com> | 2023-06-15 16:37:52 +1000 |
---|---|---|
committer | Sean Christopherson <seanjc@google.com> | 2023-07-28 15:58:53 -0700 |
commit | 2837dd00f8fc69111cd6b1dc8481d2fb490d11c9 (patch) | |
tree | 2848b357ee0b0505bac3a797a7c0716b269460dc /arch/x86/include/asm/cpufeatures.h | |
parent | f8d808ed1ba0019997f18ff2be0cf85e33a31022 (diff) | |
download | lwn-2837dd00f8fc69111cd6b1dc8481d2fb490d11c9.tar.gz lwn-2837dd00f8fc69111cd6b1dc8481d2fb490d11c9.zip |
KVM: SEV-ES: explicitly disable debug
SVM/SEV enable debug registers intercepts to skip swapping DRs
on entering/exiting the guest. When the guest is in control of
debug registers (vcpu->guest_debug == 0), there is an optimisation to
reduce the number of context switches: intercepts are cleared and
the KVM_DEBUGREG_WONT_EXIT flag is set to tell KVM to do swapping
on guest enter/exit.
The same code also executes for SEV-ES, however it has no effect as
- it always takes (vcpu->guest_debug == 0) branch;
- KVM_DEBUGREG_WONT_EXIT is set but DR7 intercept is not cleared;
- vcpu_enter_guest() writes DRs but VMRUN for SEV-ES swaps them
with the values from _encrypted_ VMSA.
Be explicit about SEV-ES not supporting debug:
- return right away from dr_interception() and skip unnecessary processing;
- return an error right away from the KVM_SEV_LAUNCH_UPDATE_VMSA handler
if debugging was already enabled.
KVM_SET_GUEST_DEBUG are failing already after KVM_SEV_LAUNCH_UPDATE_VMSA
is finished due to vcpu->arch.guest_state_protected set to true.
Add WARN_ON to kvm_x86::sync_dirty_debug_regs() (saves guest DRs on
guest exit) to signify that SEV-ES won't hit that path.
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Alexey Kardashevskiy <aik@amd.com>
Link: https://lore.kernel.org/r/20230615063757.3039121-5-aik@amd.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'arch/x86/include/asm/cpufeatures.h')
0 files changed, 0 insertions, 0 deletions