diff options
| author | Jeff Dike <jdike@addtoit.com> | 2006-05-01 12:16:00 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-05-01 18:17:44 -0700 |
| commit | 2ace87b9502d922397cabaf07d73e0b60c480ecf (patch) | |
| tree | b354425542c4b2cff20dc20cd65d0e8eeec2c7c4 /arch/um/os-Linux/file.c | |
| parent | 347b3dc2faf34d63a96b41e3244b743cc72a2aa0 (diff) | |
| download | lwn-2ace87b9502d922397cabaf07d73e0b60c480ecf.tar.gz lwn-2ace87b9502d922397cabaf07d73e0b60c480ecf.zip | |
[PATCH] uml: error handling fixes
Blairsorblade noticed some confusion between our use of a system
call's return value and errno. This patch fixes a number of related
bugs -
using errno instead of a return value
using a return value instead of errno
forgetting to negate a error return to get a positive error code
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/um/os-Linux/file.c')
| -rw-r--r-- | arch/um/os-Linux/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c index 3bd10deea280..09251338d99e 100644 --- a/arch/um/os-Linux/file.c +++ b/arch/um/os-Linux/file.c @@ -171,7 +171,7 @@ int os_sigio_async(int master, int slave) flags = fcntl(master, F_GETFL); if(flags < 0) - return errno; + return -errno; if((fcntl(master, F_SETFL, flags | O_NONBLOCK | O_ASYNC) < 0) || (fcntl(master, F_SETOWN, os_getpid()) < 0)) |