diff options
| author | Michael Neuling <mikey@neuling.org> | 2013-12-16 15:12:43 +1100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-02-15 19:20:16 +0000 |
| commit | c58ad1af9efe5fedc1e35362e53d4329a9e288e7 (patch) | |
| tree | 9fee75b929e1824ce193759a4534371a7748fcac /arch/score | |
| parent | d9bd24c3bc422acf43f744124d6537921719352f (diff) | |
| download | lwn-c58ad1af9efe5fedc1e35362e53d4329a9e288e7.tar.gz lwn-c58ad1af9efe5fedc1e35362e53d4329a9e288e7.zip | |
powerpc: Fix bad stack check in exception entry
commit 90ff5d688e61f49f23545ffab6228bd7e87e6dc7 upstream.
In EXCEPTION_PROLOG_COMMON() we check to see if the stack pointer (r1)
is valid when coming from the kernel. If it's not valid, we die but
with a nice oops message.
Currently we allocate a stack frame (subtract INT_FRAME_SIZE) before we
check to see if the stack pointer is negative. Unfortunately, this
won't detect a bad stack where r1 is less than INT_FRAME_SIZE.
This patch fixes the check to compare the modified r1 with
-INT_FRAME_SIZE. With this, bad kernel stack pointers (including NULL
pointers) are correctly detected again.
Kudos to Paulus for finding this.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'arch/score')
0 files changed, 0 insertions, 0 deletions