diff options
| author | Jesper Juhl <jesper.juhl@gmail.com> | 2006-02-04 20:35:59 +0100 |
|---|---|---|
| committer | Paul Mackerras <paulus@samba.org> | 2006-02-07 21:51:53 +1100 |
| commit | 95eff20feb679a2223a6da1e7f272fe9aa99591e (patch) | |
| tree | 1a4e2a5d8c5d8a4f8511e491705e2e220065ce5d /arch/powerpc/kernel/rtas_flash.c | |
| parent | 4009d980224389c33dce1565e0ac9f673354c43f (diff) | |
| download | lwn-95eff20feb679a2223a6da1e7f272fe9aa99591e.tar.gz lwn-95eff20feb679a2223a6da1e7f272fe9aa99591e.zip | |
[PATCH] Don't check pointer for NULL before passing it to kfree [arch/powerpc/kernel/rtas_flash.c]
Checking a pointer for NULL before passing it to kfree is pointless, kfree
does its own NULL checking of input.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Diffstat (limited to 'arch/powerpc/kernel/rtas_flash.c')
| -rw-r--r-- | arch/powerpc/kernel/rtas_flash.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c index 50500093c97f..aaf384c3f04a 100644 --- a/arch/powerpc/kernel/rtas_flash.c +++ b/arch/powerpc/kernel/rtas_flash.c @@ -672,8 +672,7 @@ static void rtas_flash_firmware(int reboot_type) static void remove_flash_pde(struct proc_dir_entry *dp) { if (dp) { - if (dp->data != NULL) - kfree(dp->data); + kfree(dp->data); dp->owner = NULL; remove_proc_entry(dp->name, dp->parent); } |