diff options
| author | Deng-Cheng Zhu <dengcheng.zhu@imgtec.com> | 2014-06-24 10:31:08 -0700 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-07-17 13:43:20 +0200 |
| commit | e7f46b90acc0848bfc2d1906e2be285c7d81afbc (patch) | |
| tree | 73325c876ebf7983e59734616ecb6ccdbb59af8a /arch/mips | |
| parent | 13fa8defdc11fa6a21315072e18a05192c4072c6 (diff) | |
| download | lwn-e7f46b90acc0848bfc2d1906e2be285c7d81afbc.tar.gz lwn-e7f46b90acc0848bfc2d1906e2be285c7d81afbc.zip | |
MIPS: KVM: Fix memory leak on VCPU
commit 8c9eb041cf76038eb3b62ee259607eec9b89f48d upstream.
kvm_arch_vcpu_free() is called in 2 code paths:
1) kvm_vm_ioctl()
kvm_vm_ioctl_create_vcpu()
kvm_arch_vcpu_destroy()
kvm_arch_vcpu_free()
2) kvm_put_kvm()
kvm_destroy_vm()
kvm_arch_destroy_vm()
kvm_mips_free_vcpus()
kvm_arch_vcpu_free()
Neither of the paths handles VCPU free. We need to do it in
kvm_arch_vcpu_free() corresponding to the memory allocation in
kvm_arch_vcpu_create().
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'arch/mips')
| -rw-r--r-- | arch/mips/kvm/kvm_mips.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/mips/kvm/kvm_mips.c b/arch/mips/kvm/kvm_mips.c index 8b900e987338..3f3e5b2b2f38 100644 --- a/arch/mips/kvm/kvm_mips.c +++ b/arch/mips/kvm/kvm_mips.c @@ -388,6 +388,7 @@ void kvm_arch_vcpu_free(struct kvm_vcpu *vcpu) kfree(vcpu->arch.guest_ebase); kfree(vcpu->arch.kseg0_commpage); + kfree(vcpu); } void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) |