diff options
| author | Geert Uytterhoeven <geert@linux-m68k.org> | 2023-09-13 16:08:35 +0200 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2023-10-06 10:03:04 +0200 |
| commit | dc40c4297760be1b0be1a4a1e6bc74f269f1ab8b (patch) | |
| tree | 3bfad77b45b5bc960ae3a9cf582435aa26ca92b7 /arch/m68k | |
| parent | 66ed28ea096c91834a18ecce26eb56a27473ce57 (diff) | |
| download | lwn-dc40c4297760be1b0be1a4a1e6bc74f269f1ab8b.tar.gz lwn-dc40c4297760be1b0be1a4a1e6bc74f269f1ab8b.zip | |
m68k: sun3: Annotate prom_printf() with __printf()
When building with W=1:
arch/m68k/sun3/prom/printf.c: In function ‘prom_printf’:
arch/m68k/sun3/prom/printf.c:35:9: warning: function ‘prom_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
35 | vsprintf(ppbuf, fmt, args);
| ^~~~~~~~
Fix this by annotating prom_printf() with __printf(1, 2).
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/61017c012617e6f633ac9f9a3c2659ae38e1f2fb.1694613528.git.geert@linux-m68k.org
Diffstat (limited to 'arch/m68k')
| -rw-r--r-- | arch/m68k/include/asm/oplib.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/m68k/include/asm/oplib.h b/arch/m68k/include/asm/oplib.h index 48cb4fd09f8d..6d5ea67c65d0 100644 --- a/arch/m68k/include/asm/oplib.h +++ b/arch/m68k/include/asm/oplib.h @@ -9,6 +9,8 @@ #ifndef __SPARC_OPLIB_H #define __SPARC_OPLIB_H +#include <linux/compiler.h> + #include <asm/openprom.h> /* The master romvec pointer... */ @@ -149,7 +151,7 @@ extern char prom_getchar(void); extern void prom_putchar(char character); /* Prom's internal printf routine, don't use in kernel/boot code. */ -void prom_printf(char *fmt, ...); +__printf(1, 2) void prom_printf(char *fmt, ...); /* Query for input device type */ |