diff options
| author | Eric Miao <eric.miao@marvell.com> | 2008-09-27 15:49:57 +0800 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-10-07 19:12:57 +0100 |
| commit | 097b53348f34a461d2b07081eae12d823cf3d729 (patch) | |
| tree | 62f59bdfc0252346666158b6c236fc250850cb36 /arch/arm/mach-pxa/spitz.c | |
| parent | 52358ba3a89012c54712c24074ceb4b1c669af52 (diff) | |
| download | lwn-097b53348f34a461d2b07081eae12d823cf3d729.tar.gz lwn-097b53348f34a461d2b07081eae12d823cf3d729.zip | |
[ARM] ohci-pxa27x: introduce flags to avoid direct access to OHCI registers
Direct access to USB host controller registers is considered to be not
portable, and is usually a bad sign for poorly abstracted interface.
Introduce .flags and .power_on_delay to "struct pxaohci_platform_data"
so that most platforms don't bother to write their own .init/.exit()
sequences.
Signed-off-by: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mach-pxa/spitz.c')
| -rw-r--r-- | arch/arm/mach-pxa/spitz.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c index 245890d2b6b5..7ef346182371 100644 --- a/arch/arm/mach-pxa/spitz.c +++ b/arch/arm/mach-pxa/spitz.c @@ -495,19 +495,13 @@ static int spitz_ohci_init(struct device *dev) */ UP2OCR = UP2OCR_HXS | UP2OCR_HXOE | UP2OCR_DPPDE | UP2OCR_DMPDE; - gpio_direction_output(SPITZ_GPIO_USB_HOST, 1); - - UHCHR = (UHCHR) & - ~(UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSEP3 | UHCHR_SSE); - - UHCRHDA |= UHCRHDA_NOCP; - - return 0; + return gpio_direction_output(SPITZ_GPIO_USB_HOST, 1); } static struct pxaohci_platform_data spitz_ohci_platform_data = { .port_mode = PMM_NPS_MODE, .init = spitz_ohci_init, + .flags = ENABLE_PORT_ALL | NO_OC_PROTECTION, .power_budget = 150, }; |