diff options
| author | Ye Guojin <ye.guojin@zte.com.cn> | 2021-11-16 06:27:26 +0000 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2021-12-17 14:08:59 +0200 |
| commit | 34596ba380b03d181e24efd50e2f21045bde3696 (patch) | |
| tree | 3c7d4d4257f61f31b0768b76e88bdd28b0f7ce84 /arch/arm/mach-omap2 | |
| parent | 80c469a0a03763f814715f3d12b6f3964c7423e8 (diff) | |
| download | lwn-34596ba380b03d181e24efd50e2f21045bde3696.tar.gz lwn-34596ba380b03d181e24efd50e2f21045bde3696.zip | |
ARM: OMAP2+: adjust the location of put_device() call in omapdss_init_of
This was found by coccicheck:
./arch/arm/mach-omap2/display.c, 272, 1-7, ERROR missing put_device;
call of_find_device_by_node on line 258, but without a corresponding
object release within this function.
Move the put_device() call before the if judgment.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/arm/mach-omap2')
| -rw-r--r-- | arch/arm/mach-omap2/display.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 6daaa645ae5d..21413a9b7b6c 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -263,9 +263,9 @@ static int __init omapdss_init_of(void) } r = of_platform_populate(node, NULL, NULL, &pdev->dev); + put_device(&pdev->dev); if (r) { pr_err("Unable to populate DSS submodule devices\n"); - put_device(&pdev->dev); return r; } |