diff options
| author | Marc Zyngier <marc.zyngier@arm.com> | 2017-03-16 18:20:49 +0000 |
|---|---|---|
| committer | Marc Zyngier <marc.zyngier@arm.com> | 2017-03-20 10:48:32 +0000 |
| commit | 90f6e150e44a0dc3883110eeb3ab35d1be42b6bb (patch) | |
| tree | 50939fe5740001b0f66c5682d66647a701047126 /arch/arm/kvm/mmu.c | |
| parent | 955a3fc6d2a1c11d6d00bce4f3816100ce0530cf (diff) | |
| download | lwn-90f6e150e44a0dc3883110eeb3ab35d1be42b6bb.tar.gz lwn-90f6e150e44a0dc3883110eeb3ab35d1be42b6bb.zip | |
arm/arm64: KVM: Take mmap_sem in stage2_unmap_vm
We don't hold the mmap_sem while searching for the VMAs when
we try to unmap each memslot for a VM. Fix this properly to
avoid unexpected results.
Fixes: commit 957db105c997 ("arm/arm64: KVM: Introduce stage2_unmap_vm")
Cc: stable@vger.kernel.org # v3.19+
Reviewed-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Diffstat (limited to 'arch/arm/kvm/mmu.c')
| -rw-r--r-- | arch/arm/kvm/mmu.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index 962616fd4ddd..f2e2e0c6d6fd 100644 --- a/arch/arm/kvm/mmu.c +++ b/arch/arm/kvm/mmu.c @@ -803,6 +803,7 @@ void stage2_unmap_vm(struct kvm *kvm) int idx; idx = srcu_read_lock(&kvm->srcu); + down_read(¤t->mm->mmap_sem); spin_lock(&kvm->mmu_lock); slots = kvm_memslots(kvm); @@ -810,6 +811,7 @@ void stage2_unmap_vm(struct kvm *kvm) stage2_unmap_memslot(kvm, memslot); spin_unlock(&kvm->mmu_lock); + up_read(¤t->mm->mmap_sem); srcu_read_unlock(&kvm->srcu, idx); } |