summaryrefslogtreecommitdiff
path: root/arch/arm/boot/dts/tegra114-dalmore.dts
diff options
context:
space:
mode:
authorJon Hunter <jonathanh@nvidia.com>2016-08-24 15:14:38 +0200
committerOlof Johansson <olof@lixom.net>2016-08-25 17:31:30 -0700
commit0a10e85b6c546c2f34ee257b955f33dbb4ece746 (patch)
treed29b15491ecbaf7bb2b01ed5c58b46c7efa7accb /arch/arm/boot/dts/tegra114-dalmore.dts
parent633af91ddb9133d65da6f3a77bb8908cdbf6aced (diff)
downloadlwn-0a10e85b6c546c2f34ee257b955f33dbb4ece746.tar.gz
lwn-0a10e85b6c546c2f34ee257b955f33dbb4ece746.zip
ARM: tegra: Correct polarity for Tegra114 PMIC interrupt
The ARM GIC only supports interrupts with either level-high or rising-edge types for SPIs. The interrupt type for the Palmas PMIC used for Tegra114 boards is specified as level-low which is invalid for the GIC. This has gone undetected because until recently, failures to set the interrupt type when the interrupts are mapped via firmware (such as device-tree) have not been reported. Since commits 4b357daed698 ("genirq: Look-up trigger type if not specified by caller") and 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ"), failure to set the interrupt type will cause the requesting of the interrupt to fail and exposing incorrectly configured interrupts. Please note that although the interrupt type was never being set for the Palmas PMIC, it was still working fine, because the default type setting for the interrupt, 'level-high', happen to match the correct type for the interrupt. Finally, it should be noted that the Palmas interrupt from the PMIC is actually 'level-low', however, this interrupt signal is inverted by the Tegra PMC and so the GIC actually sees a 'level-high' interrupt which is what should be specified in the device-tree interrupt specifier. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Olof Johansson <olof@lixom.net>
Diffstat (limited to 'arch/arm/boot/dts/tegra114-dalmore.dts')
-rw-r--r--arch/arm/boot/dts/tegra114-dalmore.dts2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index 1dfc492cc004..1444fbd543e7 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -897,7 +897,7 @@
palmas: tps65913@58 {
compatible = "ti,palmas";
reg = <0x58>;
- interrupts = <0 86 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
#interrupt-cells = <2>;
interrupt-controller;