diff options
author | H. Nikolaus Schaller <hns@goldelico.com> | 2020-07-01 08:18:27 +0200 |
---|---|---|
committer | Masahiro Yamada <masahiroy@kernel.org> | 2020-07-07 11:21:00 +0900 |
commit | 736bb11898ef748da1d805f40d485b66ceac9a3c (patch) | |
tree | ed1b6ca37a65a471fded63ad12655d6ce75af48b /Makefile | |
parent | dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258 (diff) | |
download | lwn-736bb11898ef748da1d805f40d485b66ceac9a3c.tar.gz lwn-736bb11898ef748da1d805f40d485b66ceac9a3c.zip |
modpost: remove use of non-standard strsep() in HOSTCC code
strsep() is neither standard C nor POSIX and used outside
the kernel code here. Using it here requires that the
build host supports it out of the box which is e.g.
not true for a Darwin build host and using a cross-compiler.
This leads to:
scripts/mod/modpost.c:145:2: warning: implicit declaration of function 'strsep' [-Wimplicit-function-declaration]
return strsep(stringp, "\n");
^
and a segfault when running MODPOST.
See also: https://stackoverflow.com/a/7219504
So let's replace this by strchr() instead of using strsep().
It does not hurt kernel size or speed since this code is run
on the build host.
Fixes: ac5100f5432967 ("modpost: add read_text_file() and get_line() helpers")
Co-developed-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'Makefile')
0 files changed, 0 insertions, 0 deletions