diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2024-09-14 03:06:20 +0900 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2024-09-24 03:06:52 +0900 |
| commit | fc1c79be45485565dc145fd03ee38bca89be8fbd (patch) | |
| tree | 9b1aff30c48880a7763909b50107a1b28391f783 /Makefile | |
| parent | cc6d281fcc7319babc6dde8f95a8b7feb1eeffd0 (diff) | |
| download | lwn-fc1c79be45485565dc145fd03ee38bca89be8fbd.tar.gz lwn-fc1c79be45485565dc145fd03ee38bca89be8fbd.zip | |
kbuild: remove unnecessary export of RUST_LIB_SRC
If RUST_LIB_SRC is defined in the top-level Makefile (via an environment
variable or command line), it is already exported.
The only situation where it is defined but not exported is when the
top-level Makefile is wrapped by another Makefile (e.g., GNUmakefile).
I cannot think of any other use cases.
I know some people use this tip to define custom variables. However,
even in that case, you can export it directly in the wrapper Makefile.
Example GNUmakefile:
export RUST_LIB_SRC = /path/to/your/sysroot/lib/rustlib/src/rust/library
include Makefile
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -578,10 +578,6 @@ else RUSTC_OR_CLIPPY = $(RUSTC) endif -ifdef RUST_LIB_SRC - export RUST_LIB_SRC -endif - # Allows the usage of unstable features in stable compilers. export RUSTC_BOOTSTRAP := 1 |