diff options
| author | Jonathan Corbet <corbet@lwn.net> | 2016-09-21 15:46:18 -0600 |
|---|---|---|
| committer | Jonathan Corbet <corbet@lwn.net> | 2016-09-21 15:53:31 -0600 |
| commit | 79c70c304b0b443429b2a0019518532c5162817a (patch) | |
| tree | e889f6002f16f6299ce07e7274990d64ce2a24ec /Documentation | |
| parent | dca22a63fd036c3ebb50212060eba0080f178126 (diff) | |
| download | lwn-79c70c304b0b443429b2a0019518532c5162817a.tar.gz lwn-79c70c304b0b443429b2a0019518532c5162817a.zip | |
docs: Remove space-before-label guidance from CodingStyle
Recent discussion has made it clear that there is no community consensus on
this particular rule. Remove it now, lest it inspire yet another set of
unwanted "cleanup" patches.
This partially reverts 865a1caa4b6b (CodingStyle: Clarify and complete
chapter 7).
Cc: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/CodingStyle | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 852253c932fe..9c61c039ccd9 100644 --- a/Documentation/CodingStyle +++ b/Documentation/CodingStyle @@ -451,9 +451,6 @@ Avoid using GW-BASIC names like ``err1:`` and ``err2:``, as you would have to renumber them if you ever add or remove exit paths, and they make correctness difficult to verify anyway. -It is advised to indent labels with a single space (not tab), so that -``diff -p`` does not confuse labels with functions. - The rationale for using gotos is: - unconditional statements are easier to understand and follow @@ -481,7 +478,7 @@ The rationale for using gotos is: goto out_buffer; } ... - out_free_buffer: + out_free_buffer: kfree(buffer); return result; } @@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err bugs`` which look like this: .. code-block:: c - err: + err: kfree(foo->bar); kfree(foo); return ret; |