diff options
| author | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2016-09-02 22:34:17 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-10-16 17:50:39 +0200 |
| commit | 257ab687d2679621118ac1468434322d7d44e546 (patch) | |
| tree | d9ace33c0cae8749453657db109eee2b29a714db /Documentation/workqueue.txt | |
| parent | b7bab5ad129477c430f3c138fd597e14916961a6 (diff) | |
| download | lwn-257ab687d2679621118ac1468434322d7d44e546.tar.gz lwn-257ab687d2679621118ac1468434322d7d44e546.zip | |
tpm_crb: fix crb_req_canceled behavior
commit 72fd50e14e46dc0edf360631bdece87c2f066a97 upstream.
The req_canceled() callback is used by tpm_transmit() periodically to
check whether the request has been canceled while it is receiving a
response from the TPM.
The TPM_CRB_CTRL_CANCEL register was cleared already in the crb_cancel
callback, which has two consequences:
* Cancel might not happen.
* req_canceled() always returns zero.
A better place to clear the register is when starting to send a new
command. The behavior of TPM_CRB_CTRL_CANCEL is described in the
section 5.5.3.6 of the PTP specification.
Fixes: 30fc8d138e91 ("tpm: TPM 2.0 CRB Interface")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/workqueue.txt')
0 files changed, 0 insertions, 0 deletions