diff options
author | Milo Kim <milo.kim@ti.com> | 2013-08-08 14:02:29 +0900 |
---|---|---|
committer | Bryan Wu <cooloney@gmail.com> | 2013-08-26 17:22:13 -0700 |
commit | 45e611bfbe18d854498c65d60703841e4a4c3c3a (patch) | |
tree | 1e7b6ad98d93d7bb1341d914433a0c098d093eca /Documentation/leds/leds-lp5521.txt | |
parent | 224604389a5295360ef36b50ca5a51806a235fcf (diff) | |
download | lwn-45e611bfbe18d854498c65d60703841e4a4c3c3a.tar.gz lwn-45e611bfbe18d854498c65d60703841e4a4c3c3a.zip |
leds: lp5523: restore legacy device attributes
git commit db6eaf8388a413a5ee1b4547ce78506b9c6456b0
(leds-lp5523: use generic firmware interface) causes an application conflict.
This interface should be maintained for compatibility.
Restored device attributes are 'engineN_mode', 'engineN_load' and
'engineN_leds'. (N = 1, 2 or 3)
A 'selftest' attribute macro is replaced with LP55xx common macro.
Those are accessed when a LED pattern is run by an application.
Use a mutex in lp5523_update_program_memory()
: This function is called when an user-application writes a 'engineN_load' file
or pattern data is loaded from generic firmware interface.
So, writing program memory should be protected.
If an error occurs on accessing this area, just it returns as -EINVAL quickly.
This error code is exact same as old driver function, lp5523_do_store_load()
because it should be kept for an user-application compatibility.
Even the driver is changed, we can use the application without re-compiling
sources.
Reported-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Milo Kim <milo.kim@ti.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'Documentation/leds/leds-lp5521.txt')
0 files changed, 0 insertions, 0 deletions