diff options
| author | Rob Herring <robh@kernel.org> | 2020-03-25 16:05:41 -0600 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2020-03-31 09:03:17 -0600 |
| commit | 7f464532b05dadc8f96acdda7093334c863e7a06 (patch) | |
| tree | 3071a6119044fa698ba04e866739d532c4a580ca /Documentation/devicetree/bindings/rng | |
| parent | 0d9a302da00af02482846a04e881f2388a4537fc (diff) | |
| download | lwn-7f464532b05dadc8f96acdda7093334c863e7a06.tar.gz lwn-7f464532b05dadc8f96acdda7093334c863e7a06.zip | |
dt-bindings: Add missing 'additionalProperties: false'
Setting 'additionalProperties: false' is frequently omitted, but is
important in order to check that there aren't extra undocumented
properties in a binding.
Ideally, we'd just add this automatically and make this the default, but
there's some cases where it doesn't work. For example, if a common
schema is referenced, then properties in the common schema aren't part
of what's considered for 'additionalProperties'. Also, sometimes there
are bus specific properties such as 'spi-max-frequency' that go into
bus child nodes, but aren't defined in the child node's schema.
So let's stick with the json-schema defined default and add
'additionalProperties: false' where needed. This will be a continual
review comment and game of wack-a-mole.
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com>
Acked-by: Stephen Boyd <sboyd@kernel.org> # clock
Acked-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'Documentation/devicetree/bindings/rng')
| -rw-r--r-- | Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 2 | ||||
| -rw-r--r-- | Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml index a9ff3cb35c5e..444be32a8a29 100644 --- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml +++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml @@ -29,6 +29,8 @@ required: - compatible - reg +additionalProperties: false + examples: - | rng@c8834000 { diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml index 42d9a38e4e1a..89ab67f20a7f 100644 --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml @@ -35,6 +35,8 @@ required: - compatible - reg +additionalProperties: false + examples: - | rng { |