diff options
author | Nirmoy Das <nirmoy.das@intel.com> | 2022-06-24 13:08:21 +0200 |
---|---|---|
committer | Ramalingam C <ramalingam.c@intel.com> | 2022-06-29 14:52:50 +0530 |
commit | a06968563775181690125091f470a8655742dcbf (patch) | |
tree | 304ee0b8b0e2b02d1f43ed0752f501ce9a700c01 /CREDITS | |
parent | 58eaa6b3fb636072a4f19e6b6c76bbf564e95b95 (diff) | |
download | lwn-a06968563775181690125091f470a8655742dcbf.tar.gz lwn-a06968563775181690125091f470a8655742dcbf.zip |
drm/i915: Fix a lockdep warning at error capture
For some platfroms we use stop_machine version of
gen8_ggtt_insert_page/gen8_ggtt_insert_entries to avoid a
concurrent GGTT access bug but this causes a circular locking
dependency warning:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ggtt->error_mutex);
lock(dma_fence_map);
lock(&ggtt->error_mutex);
lock(cpu_hotplug_lock);
Fix this by calling gen8_ggtt_insert_page/gen8_ggtt_insert_entries
directly at error capture which is concurrent GGTT access safe because
reset path make sure of that.
v2: Fix rebase conflict and added a comment.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5595
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220624110821.29190-1-nirmoy.das@intel.com
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions