diff options
| author | Matthew Wilcox (Oracle) <willy@infradead.org> | 2022-01-17 14:46:55 -0500 |
|---|---|---|
| committer | Matthew Wilcox (Oracle) <willy@infradead.org> | 2022-03-21 13:01:35 -0400 |
| commit | c79b7b96db8b1240887686720cd149f2c5d979d6 (patch) | |
| tree | 0e88e7a5009ad790d18315c4448706583b1412bc | |
| parent | 343b288834e84d0b175b20b4f48277bc33260986 (diff) | |
| download | lwn-c79b7b96db8b1240887686720cd149f2c5d979d6.tar.gz lwn-c79b7b96db8b1240887686720cd149f2c5d979d6.zip | |
mm/vmscan: Account large folios correctly
The statistics we gather should count the number of pages, not the
number of folios. The logic in this function is somewhat convoluted,
but even if we split the folio, I think the accounting is now correct.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
| -rw-r--r-- | mm/vmscan.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/mm/vmscan.c b/mm/vmscan.c index 8243437e5c5f..d57b376593f8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1575,10 +1575,10 @@ retry: */ folio_check_dirty_writeback(folio, &dirty, &writeback); if (dirty || writeback) - stat->nr_dirty++; + stat->nr_dirty += nr_pages; if (dirty && !writeback) - stat->nr_unqueued_dirty++; + stat->nr_unqueued_dirty += nr_pages; /* * Treat this page as congested if the underlying BDI is or if @@ -1590,7 +1590,7 @@ retry: if (((dirty || writeback) && mapping && inode_write_congested(mapping->host)) || (writeback && PageReclaim(page))) - stat->nr_congested++; + stat->nr_congested += nr_pages; /* * If a page at the tail of the LRU is under writeback, there @@ -1639,7 +1639,7 @@ retry: if (current_is_kswapd() && PageReclaim(page) && test_bit(PGDAT_WRITEBACK, &pgdat->flags)) { - stat->nr_immediate++; + stat->nr_immediate += nr_pages; goto activate_locked; /* Case 2 above */ @@ -1657,7 +1657,7 @@ retry: * and it's also appropriate in global reclaim. */ SetPageReclaim(page); - stat->nr_writeback++; + stat->nr_writeback += nr_pages; goto activate_locked; /* Case 3 above */ @@ -1823,7 +1823,7 @@ retry: case PAGE_ACTIVATE: goto activate_locked; case PAGE_SUCCESS: - stat->nr_pageout += thp_nr_pages(page); + stat->nr_pageout += nr_pages; if (PageWriteback(page)) goto keep; |