summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsunliming <sunliming@kylinos.cn>2023-06-26 19:13:42 +0800
committerSteven Rostedt (Google) <rostedt@goodmis.org>2023-06-28 11:00:50 -0400
commitf6d026eea390d59787a6cdc2ef5c983d02e029d0 (patch)
tree821dea1d68244e15bf4b506b9f8d5b2deda11ebe
parent0113d4615dbf053ae9a7a1e0acbc6652713af01f (diff)
downloadlwn-f6d026eea390d59787a6cdc2ef5c983d02e029d0.tar.gz
lwn-f6d026eea390d59787a6cdc2ef5c983d02e029d0.zip
tracing/user_events: Fix incorrect return value for writing operation when events are disabled
The writing operation return the count of writes regardless of whether events are enabled or disabled. Switch it to return -EBADF to indicates that the event is disabled. Link: https://lkml.kernel.org/r/20230626111344.19136-2-sunliming@kylinos.cn Cc: stable@vger.kernel.org 7f5a08c79df35 ("user_events: Add minimal support for trace_event into ftrace") Acked-by: Beau Belgrave <beaub@linux.microsoft.com> Signed-off-by: sunliming <sunliming@kylinos.cn> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-rw-r--r--kernel/trace/trace_events_user.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 8df0550415e7..09f7d9167b8e 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -2096,7 +2096,8 @@ static ssize_t user_events_write_core(struct file *file, struct iov_iter *i)
if (unlikely(faulted))
return -EFAULT;
- }
+ } else
+ return -EBADF;
return ret;
}